Skip to content

[codex] Add optional skill auto publish after review#15022

Merged
KomachiSion merged 1 commit into
alibaba:developfrom
shiyiyue1102:codex-skill-auto-publish-after-review
May 7, 2026
Merged

[codex] Add optional skill auto publish after review#15022
KomachiSion merged 1 commit into
alibaba:developfrom
shiyiyue1102:codex-skill-auto-publish-after-review

Conversation

@shiyiyue1102

@shiyiyue1102 shiyiyue1102 commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Fixes #15023

Summary

This PR adds an opt-in switch for skill versions to be published automatically after the review pipeline approves them.

Changes

  • Add nacos.ai.skill.auto-publish-after-review.enabled, defaulting to false for compatibility.
  • Route skill pipeline completion through a skill-specific callback that publishes approved versions only when the switch is enabled.
  • Add a system publish path for pipeline callbacks so auto-publish does not depend on request-scoped user visibility context.
  • Document the new property in distribution/conf/application.properties.
  • Ignore local tool directories .qoder/ and openspec/.

Validation

  • git diff --cached --check
  • mvn -pl ai -Dtest=SkillOperationServiceImplTest#testSubmitAutoPublishWhenPipelineApproved+testSubmitShouldNotAutoPublishByDefaultWhenPipelineApproved test

Notes

pom.xml local version change for packaging/debugging was intentionally not included in this PR.

Change-Id: Ib51f46bdfc244aa62b9c910ff866e8b209daf6db
Assisted-by: Claude Code
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/ai/service/skills/SkillOperationServiceImpl.java 72.22% 3 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@KomachiSion
KomachiSion marked this pull request as ready for review May 7, 2026 02:57
@KomachiSion KomachiSion added the kind/feature type/feature label May 7, 2026
@KomachiSion KomachiSion added this to the 3.2.2 milestone May 7, 2026
@KomachiSion
KomachiSion merged commit 83541b2 into alibaba:develop May 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support optional auto-publish for approved skill review results

3 participants