Skip to content

Fix config namespace isolation for ID-based operations#15497

Merged
KomachiSion merged 1 commit into
alibaba:v2.x-developfrom
KomachiSion:codex/2x-config-namespace-isolation
Jul 13, 2026
Merged

Fix config namespace isolation for ID-based operations#15497
KomachiSion merged 1 commit into
alibaba:v2.x-developfrom
KomachiSion:codex/2x-config-namespace-isolation

Conversation

@KomachiSion

Copy link
Copy Markdown
Collaborator

Summary

  • Scope config export and batch delete by namespace when IDs are provided
  • Scope clone source IDs by source namespace and require source READ permission
  • Keep legacy console clone requests passing the source namespace and include generated static assets
  • Add small build-stability fixes needed for the v2.x JDK8 release build

Verification

  • LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_411.jdk/Contents/Home PATH=/Library/Java/JavaVirtualMachines/jdk1.8.0_411.jdk/Contents/Home/bin:$PATH mvn clean install -Prelease-nacos
  • JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_411.jdk/Contents/Home PATH=/Library/Java/JavaVirtualMachines/jdk1.8.0_411.jdk/Contents/Home/bin:$PATH mvn -pl config -Dtest=ConfigChangeAspectTest#testRpcSourceTypeHandling test
  • LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_411.jdk/Contents/Home PATH=/Library/Java/JavaVirtualMachines/jdk1.8.0_411.jdk/Contents/Home/bin:$PATH mvn -pl client -Dtest=DiskCacheTest,DiskFailoverDataSourceTest test
  • JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_411.jdk/Contents/Home PATH=/Library/Java/JavaVirtualMachines/jdk1.8.0_411.jdk/Contents/Home/bin:$PATH mvn -pl client checkstyle:check -DskipTests

Note: the full JDK8 build was run with a UTF-8 locale because this shell otherwise reports file.encoding=US-ASCII under LC_ALL=C, which breaks existing Chinese test resources.

Scope config ID-based export and batch delete by tenant, add sourceTenant handling and source namespace READ auth for clone, and rebuild legacy console UI assets.

Also add the form size default fallback needed by the latest v2.x branch.

Assisted-by: Claude Code
@github-actions

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@KomachiSion KomachiSion added area/Config kind/bug Category issues or prs related to bug. version/2.x labels Jul 13, 2026
@KomachiSion KomachiSion added this to the 2.5.3 milestone Jul 13, 2026
@KomachiSion
KomachiSion merged commit 60e311f into alibaba:v2.x-develop Jul 13, 2026
3 checks passed
@KomachiSion
KomachiSion deleted the codex/2x-config-namespace-isolation branch July 13, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/Config kind/bug Category issues or prs related to bug. version/2.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant