This repository was archived by the owner on Aug 2, 2024. It is now read-only.
Updates Compose to alpha07#670
Merged
Merged
Conversation
florina-muntenescu
approved these changes
Nov 9, 2020
florina-muntenescu
left a comment
florina-muntenescu
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good. one extra question. feel free to merge after it's addressed
| implementation "androidx.ui:ui-tooling:$rootProject.composeVersion" | ||
| implementation "androidx.compose.runtime:runtime-livedata:$rootProject.composeVersion" | ||
| implementation "com.google.android.material:compose-theme-adapter:$rootProject.composeVersion" | ||
| // implementation "com.google.android.material:compose-theme-adapter:$rootProject.composeVersion" |
Contributor
There was a problem hiding this comment.
should this be removed rather than commented out?
There was a problem hiding this comment.
I'd keep it, we'll need to revert back to this for the actual release.
Contributor
Author
There was a problem hiding this comment.
+1, I left it commented out so that we don't forget to revert it
chrisbanes
approved these changes
Nov 9, 2020
| implementation "androidx.ui:ui-tooling:$rootProject.composeVersion" | ||
| implementation "androidx.compose.runtime:runtime-livedata:$rootProject.composeVersion" | ||
| implementation "com.google.android.material:compose-theme-adapter:$rootProject.composeVersion" | ||
| // implementation "com.google.android.material:compose-theme-adapter:$rootProject.composeVersion" |
There was a problem hiding this comment.
I'd keep it, we'll need to revert back to this for the actual release.
tiembo
approved these changes
Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.