setForegroundServiceTimeoutMs called before setMediaNotificationProvider will silently break setMediaNotificationProvider

[nift4]

Version

Media3 1.6.0

More version details

No response

Devices that reproduce the issue

any

Devices that do not reproduce the issue

N/A

Reproducible in the demo app?

Yes

Reproduction steps

        setForegroundServiceTimeoutMs(120000)
        setMediaNotificationProvider(
            DefaultMediaNotificationProvider.Builder(this)
                .build()
                .also { it.setSmallIcon(androidx.media3.session.R.drawable.media3_icon_heart_filled) }
        )

in onCreate

Expected result

Heart icon in notification

Actual result

Custom media notification provider is not applied, default provider (-> default icon) is used.

setForegroundServiceTimeoutMs instantiates the MediaNotificationManager, which reads from this.mediaNotificationProvider field, but if we set the field after manager is already created, nothing will happen.

I believe this should be documented, and setMediaNotificationProvider() should just throw IllegalStateException if MediaNotificationManager already created.

Media

Not applicable

Bug Report

• You will email the zip file produced by adb bugreport to android-media-github@google.com after filing this issue.

[Androidrwcwride2]

It should be only one Source Android.X.Media Overview for Android Developers.com and nothing else on all of them but I don't know why it won't change for me could you help because I'm the only one doing this I have No children and the only browser I want is Firefox Nightly Android Developer but it won't give it to me can you please help it needs to be fixed Thanks Randy Wilson androidrwcwride2

[marcbaechinger]

Thanks for reporting!

[tonihei]

This is fixed by the commit above. The methods can be called in any order now.

[nift4]

Thanks!