VorbisComment keys should be compared case-insensitively

[artur-shaik]

Use case description

There is no icy-title tag in ogg formated stream, this leads to the fact that all android apps that use this lib cannot display current playing metadata.

here is ffprobe results:

ffprobe -show_streams -show_format https://ice.coldstar.online/high.ogg
...
Input #0, ogg, from 'https://ice.coldstar.online/high.ogg':
  Metadata:
    icy-index-metadata: 1
    icy-logo        : https://coldstar.online/static/assets/firefox_app_512x512.png
    icy-country-code: kg
    icy-language-codes: en,ru
    icy-main-stream-url: https://ice.coldstar.online/high.ogg
    icy-genre       : trance,house
    icy-description : Description
    icy-name        : ColdStar.Online Radio (High quality)
    icy-pub         : 1
  Duration: N/A, start: 5552.966667, bitrate: 256 kb/s
  Stream #0:0: Audio: vorbis, 48000 Hz, stereo, fltp, 256 kb/s
    Metadata:
      title           : Solarstone - Pure Trance Radio 384 (2023-11-29)
      server          : Icecast 2.4.4
...

Proposed solution

Consider parsing title tag in ogg stream.

Alternatives considered

Tryied to apply icy-title to ogg stream manually, but it turned out that it just doesn't support it.

[icbaker]

When I play https://ice.coldstar.online/high.ogg in the demo app, I see the following in logcat:

Metadata [
  VC: title=GroupTherapy 558: Sultan + Shepard ft. Nathan Nicholson - Under The Surface 
  VC: server=Icecast 2.4.4
  IcyHeaders: name="Coldstar Online", genre="trance,house", bitrate=-1, metadataInterval=-1
]

VC = VorbisComment

So it looks like the title is being parsed.

It doesn't seem to be propagated to MediaMetadata.title (I listened to Player.Listener.onMediaMetadataChanged in the demo app, and it was always title=null).

I checked the implementation of VorbisComment.populateMediaMetadata and it is checking for a tag with key="TITLE" (case sensitive) - whereas this stream has key="title". Modifying the implementation to be case insensitive emits the following from onMediaMetadataChanged:

mediaMetadata.title=GroupTherapy 558: A.M.R - Here We Are

Checking for "TITLE" probably comes from this spec: https://xiph.org/vorbis/doc/v-comment.html - but it looks like we missed this bit (emphasis mine): "A case-insensitive field name".

I'll update the implementation of VorbisComment.populateMediaMetadata to be case-insensitive when comparing key names.

If this doesn't resolve your issue, or I've misunderstood the problem, please do clarify :)

[artur-shaik]

That sounds like a solution for this issue.