Add getter for ShuffleOrder#2522
Merged
Merged
Conversation
Contributor
Author
|
Hi @marcbaechinger, can you please take a look at this fairily simple PR? Thank you :) |
marcbaechinger
force-pushed
the
getshuffle
branch
from
July 9, 2025 16:56
263df8c to
5022d38
Compare
Contributor
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
marcbaechinger
force-pushed
the
getshuffle
branch
from
July 9, 2025 17:33
5022d38 to
74ab7ef
Compare
Contributor
Author
|
Thank you! |
icbaker
pushed a commit
that referenced
this pull request
Jul 24, 2025
PiperOrigin-RevId: 781950733 (cherry picked from commit af6fa9e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing playback resumption, I want to save/restore shuffle order as well. But I can't just use the last shuffle order I set as the shuffle order changes with every playlist change. Add a getter for shuffle order.