PIP-122: change loadbalance shedder to ThresholdShedder and add test#13733
Merged
codelipenghui merged 4 commits intoJan 28, 2022
Conversation
github-actions
Bot
added
the
doc-required
hangc0276
requested review from
315157973,
codelipenghui,
gaoran10,
hezhangjian,
michaeljmarshall and
zymap
January 13, 2022 03:53
hangc0276
changed the title
merlimat
approved these changes
Jan 22, 2022
michaeljmarshall
approved these changes
Jan 23, 2022
michaeljmarshall
left a comment
michaeljmarshall
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for adding thorough tests @hangc0276!
codelipenghui
approved these changes
Jan 25, 2022
hangc0276
force-pushed
the
chenhang/change_default_loadbalance_shedder_to_thresholdShedder
branch
from
January 27, 2022 09:10
2100ea8 to
d71306f
Compare
Anonymitaet
added
doc-complete
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13340
Modification
OverloadSheddertoThresholdShedderThresholdShedderDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)