[Issue 14013][broker] make triggerOffload method async#14027
Merged
Conversation
HQebupt
changed the title
Contributor
Author
|
/pulsarbot rerun-failure-checks |
HQebupt
force-pushed
the
issue-14013-triggerOffload
branch
from
January 29, 2022 04:48
914a691 to
061c9dc
Compare
19 tasks
HQebupt
force-pushed
the
issue-14013-triggerOffload
branch
from
January 29, 2022 06:49
803d9e2 to
003711a
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jan 29, 2022
mattisonchao
approved these changes
Jan 30, 2022
mattisonchao
left a comment
mattisonchao
left a comment
Member
There was a problem hiding this comment.
LGTM +1.
but I have a suggestion:
- Remove asyncResponse from the internal method, and unified exception and result handling are performed at the controller layer, which makes the internal method purer.
Contributor
Author
|
@Jason918 PTAL, thanks |
Jason918
approved these changes
Jan 31, 2022
19 tasks
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #14013
Motivation
See #14013
Verifying this change
Make sure that the change passes the CI checks.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-doc