Skip to content

__ is reserved for introspection#2805

Merged
yaacovCR merged 2 commits into
ardatan:masterfrom
saerdnaer:fix-fake
Apr 12, 2021
Merged

__ is reserved for introspection#2805
yaacovCR merged 2 commits into
ardatan:masterfrom
saerdnaer:fix-fake

Conversation

@saerdnaer

@saerdnaer saerdnaer commented Apr 6, 2021

Copy link
Copy Markdown
Contributor

Related #2804

graphql "__fake" must not begin with "__", which is reserved by GraphQL introspection.

c.f. graphql/graphql-spec#244

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot

changeset-bot Bot commented Apr 6, 2021

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7322572

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-tools/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphql "__fake" must not begin with "__", which is reserved by GraphQL introspection.

c.f. graphql/graphql-spec#244
@ardatan

ardatan commented Apr 7, 2021

Copy link
Copy Markdown
Owner

Thanks for the fix :) Could you add a changeset using yarn changeset?

@saerdnaer

Copy link
Copy Markdown
Contributor Author

Done – but I'm not sure if I answered the questions correctly...

@ardatan
ardatan requested a review from yaacovCR April 12, 2021 14:51
@yaacovCR
yaacovCR merged commit a4f1ee5 into ardatan:master Apr 12, 2021
@saerdnaer
saerdnaer deleted the fix-fake branch April 12, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants