[Merged by Bors] - Rename get_multiple APIs to get_many#4384
Closed
alice-i-cecile wants to merge 2 commits into
Closed
[Merged by Bors] - Rename get_multiple APIs to get_many#4384alice-i-cecile wants to merge 2 commits into
alice-i-cecile wants to merge 2 commits into
Conversation
This gives us consistency with std's new APIs rust-lang/rust#83608
alice-i-cecile
added
A-ECS
Member
Author
|
Adding to the 0.7 milestone as we already have Cart's approval of this change, and it's nice to avoid introducing pointless API breakage.
|
Member
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Mar 31, 2022
# Objective - std's new APIs do the same thing as `Query::get_multiple_mut`, but are called `get_many`: rust-lang/rust#83608 ## Solution - Find and replace `get_multiple` with `get_many`
bors
Bot
changed the title
bors Bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
We missed a couple of these renames in #4384
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - std's new APIs do the same thing as `Query::get_multiple_mut`, but are called `get_many`: rust-lang/rust#83608 ## Solution - Find and replace `get_multiple` with `get_many`
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
We missed a couple of these renames in bevyengine#4384
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - std's new APIs do the same thing as `Query::get_multiple_mut`, but are called `get_many`: rust-lang/rust#83608 ## Solution - Find and replace `get_multiple` with `get_many`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
We missed a couple of these renames in bevyengine#4384
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Query::get_multiple_mut, but are calledget_many: Add slice methods for indexing via an array of indices. rust-lang/rust#83608Solution
get_multiplewithget_many