Output scopes field even when empty#65
Merged
Merged
Conversation
maksbotan
approved these changes
Oct 26, 2022
maksbotan
left a comment
maksbotan
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks for the catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, setting the OAuth2 scopes to an empty map omits the field
scopesfrom the flow object. However, according to this guide thescopesfield should contain an empty object{}when the map is empty (which it MAY be according to the spec).This PR fixes this issue so that the
scopesfield is always present even when empty.