Add support for protoc toolchains#108
Merged
Merged
Conversation
srikrsna-buf
changed the title
ghost
approved these changes
May 22, 2025
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Looks pretty good to me.
P.S.: Any chance we can test the example project in CI? (I actually wonder a bit about whether we should do that for all of them... but maybe not worth it.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for protoc toolchains. This is currently behind a flag
--incompatible_enable_proto_toolchain_resolutionCloses #74