Specs pass under ruby 3.3 and 3.4#2749
Merged
Merged
Conversation
Some textual output in Ruby 3.4 has been change which caused hard-coded expectations to be incorrect, e.g. Hash's string representation changed spacing. This commit resolves this difference by relying on Ruby's interpolation for objects, rather than hard-coding a specific iterpolation into specs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (20)
💤 Files with no reviewable changes (1)
WalkthroughThe PR reformats a YAML test fixture to use explicit multi-line list entries. It also updates multiple unit and integration spec expectations to match revised string representations for validation errors, logged messages, rendered templates, config fingerprints, digests, and RPC exception text. Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
selzoc
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some textual output in Ruby 3.4 has been change which caused hard-coded expectations to be incorrect, e.g. Hash's string representation changed spacing.
This commit resolves this difference by relying on Ruby's interpolation for objects, rather than hard-coding a specific iterpolation into specs.
Should fix (most) failures in: #2748