Skip to content

Specs pass under ruby 3.3 and 3.4#2749

Merged
aramprice merged 1 commit into
mainfrom
tests-are-ruby-version-agnostic
Jun 24, 2026
Merged

Specs pass under ruby 3.3 and 3.4#2749
aramprice merged 1 commit into
mainfrom
tests-are-ruby-version-agnostic

Conversation

@aramprice

Copy link
Copy Markdown
Member

Some textual output in Ruby 3.4 has been change which caused hard-coded expectations to be incorrect, e.g. Hash's string representation changed spacing.
This commit resolves this difference by relying on Ruby's interpolation for objects, rather than hard-coding a specific iterpolation into specs.

Should fix (most) failures in: #2748

Some textual output in Ruby 3.4 has been change which caused
hard-coded expectations to be incorrect, e.g. Hash's string
representation changed spacing.
This commit resolves this difference by relying on Ruby's
interpolation for objects, rather than hard-coding a specific
iterpolation into specs.
Copilot AI review requested due to automatic review settings June 24, 2026 22:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 362ab59b-3778-48ae-afa0-185260cbfbb9

📥 Commits

Reviewing files that changed from the base of the PR and between 00b9ab6 and d92e317.

📒 Files selected for processing (20)
  • src/bosh-director/spec/assets/test-director-config.yml
  • src/bosh-director/spec/unit/bosh/director/addon/addon_spec.rb
  • src/bosh-director/spec/unit/bosh/director/addon/filter_spec.rb
  • src/bosh-director/spec/unit/bosh/director/agent_broadcaster_spec.rb
  • src/bosh-director/spec/unit/bosh/director/api/instance_lookup_spec.rb
  • src/bosh-director/spec/unit/bosh/director/config_spec.rb
  • src/bosh-director/spec/unit/bosh/director/core/templates/source_erb_spec.rb
  • src/bosh-director/spec/unit/bosh/director/cpi_config/cpi_spec.rb
  • src/bosh-director/spec/unit/bosh/director/deployment_plan/deployment_spec_parser_spec.rb
  • src/bosh-director/spec/unit/bosh/director/deployment_plan/instance_spec.rb
  • src/bosh-director/spec/unit/bosh/director/deployment_plan/planner_factory_spec.rb
  • src/bosh-director/spec/unit/bosh/director/deployment_plan/release_version_exported_from_spec.rb
  • src/bosh-director/spec/unit/bosh/director/deployment_plan/stemcell_spec.rb
  • src/bosh-director/spec/unit/bosh/director/errand/errand_provider_spec.rb
  • src/bosh-director/spec/unit/bosh/director/errand/lifecycle_errand_step_spec.rb
  • src/bosh-director/spec/unit/bosh/director/errand/lifecycle_service_step_spec.rb
  • src/bosh-director/spec/unit/bosh/director/errand/runner_spec.rb
  • src/bosh-director/spec/unit/bosh/director/runtime_config/release_spec.rb
  • src/spec/integration/cli_deployment_process_spec.rb
  • src/spec/integration/deploy_instance_groups_job_spec.rb
💤 Files with no reviewable changes (1)
  • src/bosh-director/spec/unit/bosh/director/config_spec.rb

Walkthrough

The PR reformats a YAML test fixture to use explicit multi-line list entries. It also updates multiple unit and integration spec expectations to match revised string representations for validation errors, logged messages, rendered templates, config fingerprints, digests, and RPC exception text.

Suggested reviewers

  • mkocher
  • neddp
  • a-hassanin
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change but omits most required template sections, including tests run, release notes, breaking change, and tags. Add the missing template sections: tests run, release note summary, breaking-change note, and tag your pair/PM/team; include any relevant context links.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the main change: making specs pass on Ruby 3.3 and 3.4.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tests-are-ruby-version-agnostic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group Jun 24, 2026
@aramprice
aramprice merged commit 67035bc into main Jun 24, 2026
22 checks passed
@aramprice
aramprice deleted the tests-are-ruby-version-agnostic branch June 24, 2026 23:07
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants