Skip to content

Add CI configuration for Ruby 4.0#2768

Merged
aramprice merged 2 commits into
mainfrom
ruby-4.0
Jul 13, 2026
Merged

Add CI configuration for Ruby 4.0#2768
aramprice merged 2 commits into
mainfrom
ruby-4.0

Conversation

@aramprice

Copy link
Copy Markdown
Member

Note: this will not cause the package to be consumed but once the code is merged and the pipeline configured the 4.0 package will be present and the release can be switched to use it.

Note that this will not cause the package to be consumed but once the
code is merged and the pipeline configured the 4.0 package will be
present and the release can be switched to use it.
@aramprice
aramprice requested review from a team, ay901246 and julian-hj and removed request for a team July 13, 2026 02:21
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The dependency bump workflow now targets Ruby 4.0, and the director source pins Ruby 4.0.5. Database configuration no longer invokes or defines the Postgres-specific Sequel thread-safety patch. The unit test files covering that patch and Sequel SQL string behavior were removed.

Suggested reviewers: a-hassanin, fmoehler, selzoc

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only includes one note and omits all required template sections like context, tests, release notes, and breaking changes. Add the required headings and fill in what changed, context, tests run, release-note text, breaking-change impact, and team tags.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the Ruby 4.0 CI/configuration update and matches the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ruby-4.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci/pipeline.yml`:
- Line 1379: Update the package watched by check-for-updated-vendored-packages
to director-ruby-4.0, matching the active PACKAGE anchor, and remove the stale
director-ruby-3.4 reference.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 30e7c75d-fda0-4a49-abb3-466b8dc0c98f

📥 Commits

Reviewing files that changed from the base of the PR and between d2ff8b6 and 4f2b1c1.

📒 Files selected for processing (5)
  • ci/pipeline.yml
  • src/.ruby-version
  • src/bosh-director/lib/bosh/director/config.rb
  • src/bosh-director/spec/unit/bosh/director/postgres_thread_safety_patch_spec.rb
  • src/bosh-director/spec/unit/bosh/director/sequel_spec.rb
💤 Files with no reviewable changes (3)
  • src/bosh-director/spec/unit/bosh/director/postgres_thread_safety_patch_spec.rb
  • src/bosh-director/spec/unit/bosh/director/sequel_spec.rb
  • src/bosh-director/lib/bosh/director/config.rb

Comment thread ci/pipeline.yml
@aramprice
aramprice requested a review from colins July 13, 2026 16:55

@colins colins left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That removes the temporary patch I applied. Thanks

@aramprice
aramprice merged commit 82751b6 into main Jul 13, 2026
24 checks passed
@aramprice
aramprice deleted the ruby-4.0 branch July 13, 2026 17:53
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants