Conversation
Note that this will not cause the package to be consumed but once the code is merged and the pipeline configured the 4.0 package will be present and the release can be switched to use it.
WalkthroughThe dependency bump workflow now targets Ruby 4.0, and the director source pins Ruby 4.0.5. Database configuration no longer invokes or defines the Postgres-specific Sequel thread-safety patch. The unit test files covering that patch and Sequel SQL string behavior were removed. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/pipeline.yml`:
- Line 1379: Update the package watched by check-for-updated-vendored-packages
to director-ruby-4.0, matching the active PACKAGE anchor, and remove the stale
director-ruby-3.4 reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 30e7c75d-fda0-4a49-abb3-466b8dc0c98f
📒 Files selected for processing (5)
ci/pipeline.ymlsrc/.ruby-versionsrc/bosh-director/lib/bosh/director/config.rbsrc/bosh-director/spec/unit/bosh/director/postgres_thread_safety_patch_spec.rbsrc/bosh-director/spec/unit/bosh/director/sequel_spec.rb
💤 Files with no reviewable changes (3)
- src/bosh-director/spec/unit/bosh/director/postgres_thread_safety_patch_spec.rb
- src/bosh-director/spec/unit/bosh/director/sequel_spec.rb
- src/bosh-director/lib/bosh/director/config.rb
colins
left a comment
There was a problem hiding this comment.
That removes the temporary patch I applied. Thanks
Note: this will not cause the package to be consumed but once the code is merged and the pipeline configured the 4.0 package will be present and the release can be switched to use it.