Skip to content

Add support for php 7.3 and php 7.4#246

Merged
florianeckerstorfer merged 17 commits into
cocur:masterfrom
snapshotpl:php74
Dec 4, 2019
Merged

Add support for php 7.3 and php 7.4#246
florianeckerstorfer merged 17 commits into
cocur:masterfrom
snapshotpl:php74

Conversation

@snapshotpl

Copy link
Copy Markdown
Contributor

No description provided.

@florianeckerstorfer

Copy link
Copy Markdown
Member

Should we just drop support for PHP5?

@florianeckerstorfer

Copy link
Copy Markdown
Member

Or at least drop PHP 5.5? I would then release a new major version on the weekend

@OskarStark

Copy link
Copy Markdown
Contributor

Definitely 👍 for dropping 5 completely 👍🏻

@snapshotpl

Copy link
Copy Markdown
Contributor Author

Great! Maybe drop also all unsupported versions: 7.0 and 7.1?

@OskarStark

Copy link
Copy Markdown
Contributor

Yes, but let’s do it step by step I would say

@snapshotpl

Copy link
Copy Markdown
Contributor Author

Ok, so pls suggest this steps

@kubawerlos

Copy link
Copy Markdown
Contributor

Drop old PHP versions and update in compsoer.json to:

"mockery/mockery": "^1.3",

@snapshotpl

Copy link
Copy Markdown
Contributor Author

@kubawerlos but @OskarStark suggest something different

@OskarStark

Copy link
Copy Markdown
Contributor

We can if you like but I know there are a lot of projects outside which use not or only security fixes mode php versions. I would only drop them if it causes more work for the maintainers or if it would not be possible to go further

@franmomu franmomu mentioned this pull request Dec 2, 2019
@franmomu

franmomu commented Dec 3, 2019

Copy link
Copy Markdown
Contributor

So since #251 was merged, what about just adding support of PHP 7.3 and 7.4 and then we'll see if it is worth it to drop 7.0 or 7.1

@florianeckerstorfer

Copy link
Copy Markdown
Member

@franmomu Sounds great

@snapshotpl

Copy link
Copy Markdown
Contributor Author

Ok guys! Now it pass all 7.x versions!

@franmomu franmomu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! @snapshotpl

@florianeckerstorfer
florianeckerstorfer merged commit 0129bfb into cocur:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants