Skip to content

fix arginfo and build warnings#3

Merged
codemasher merged 1 commit into
codemasher:mainfrom
remicollet:issue-warn
Jul 10, 2021
Merged

fix arginfo and build warnings#3
codemasher merged 1 commit into
codemasher:mainfrom
remicollet:issue-warn

Conversation

@remicollet

Copy link
Copy Markdown

No description provided.

@codemasher

Copy link
Copy Markdown
Owner

I remember changing this here because it broke the build in Windows. I've checked with this PR and still getting ext\xz\utils.c(32): error C2036: 'void *': unknown size [...].

@remicollet

Copy link
Copy Markdown
Author

Please try with new version

@codemasher

Copy link
Copy Markdown
Owner

That looks good! (tested with the php-8.0 dev branch)

@codemasher
codemasher merged commit 6ebbf3d into codemasher:main Jul 10, 2021
@remicollet
remicollet deleted the issue-warn branch July 10, 2021 11:32
@remicollet

remicollet commented Jul 10, 2021

Copy link
Copy Markdown
Author

Perhaps worth a new version ?

I still like to check the read/write for stream, especially the error check, and the API in PHP >= 7.4 (error return -1) but won't have time in the next days

@codemasher

Copy link
Copy Markdown
Owner

Yes, i'm going to tag a new release - i have no problem to wait a few more days as i'm no C expert and i appreciate your contributions!
One thing i'd like to do is to add Windows builds to CI but from what it looks it's... complicated. Do you perhaps know of a php extension repo that has already accomplished that for GitHub actions?

@remicollet

Copy link
Copy Markdown
Author

Yes, i'm going to tag a new release - i have no problem to wait a few more days as i'm no C expert and i appreciate your contributions!
One thing i'd like to do is to add Windows builds to CI but from what it looks it's... complicated. Do you perhaps know of a php extension repo that has already accomplished that for GitHub actions?

Perhaps @cmb69 may help for Windows CI ?

@cmb69

cmb69 commented Jul 13, 2021

Copy link
Copy Markdown

See https://github.com/php/pecl-database-dbase/tree/master/.github/workflows (which uses https://github.com/cmb69/setup-php-sdk). There is no support for installing the dependency libraries yet (not even for the core dependencies), but in your case just fetching and unpacking liblzma might be sufficient for now.

@codemasher

Copy link
Copy Markdown
Owner

This is what i was looking for - thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants