Skip to content

Letter 'g' from #428#477

Merged
larsoner merged 3 commits into
codespell-project:masterfrom
luzpaz:letter/g
May 8, 2018
Merged

Letter 'g' from #428#477
larsoner merged 3 commits into
codespell-project:masterfrom
luzpaz:letter/g

Conversation

@luzpaz

@luzpaz luzpaz commented Apr 29, 2018

Copy link
Copy Markdown
Collaborator

Continuing to separate #428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.

@codecov-io

codecov-io commented Apr 29, 2018

Copy link
Copy Markdown

Codecov Report

Merging #477 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files           3        3           
  Lines         704      704           
  Branches      100      100           
=======================================
  Hits          625      625           
  Misses         60       60           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9f24c4...5f75c47. Read the comment docs.

Comment thread codespell_lib/data/dictionary.txt Outdated
Ghandi->Gandhi
ghraphic->graphic
gioen->given
gird->grid

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word gird is valid, this correction should be removed.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsoner

larsoner commented May 4, 2018

Copy link
Copy Markdown
Member

Needs rebase

@larsoner

larsoner commented May 4, 2018

Copy link
Copy Markdown
Member

Also @luzpaz you should be pulling from #436 not #428, right?

@luzpaz luzpaz force-pushed the letter/g branch 3 times, most recently from f17da6d to 15dad4f Compare May 8, 2018 01:14
@luzpaz

luzpaz commented May 8, 2018

Copy link
Copy Markdown
Collaborator Author

rebased and ready for merge

Comment thread codespell_lib/data/dictionary.txt Outdated
genarated->generated
genarating->generating
genaration->generation
geneic->generic

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also "genetic"

Comment thread codespell_lib/data/dictionary.txt Outdated
geographicial->geographical
geomery->geometry
geometites->geometries
geometrc->geometry

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"geometric" should probably be first

Comment thread codespell_lib/data/dictionary.txt Outdated
greysacles->greyscales
gridles->griddles
grometry->geometry
grop->drop

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or "group"

luzpaz added 3 commits May 8, 2018 10:05
Continuing to separate codespell-project#428 in to separate PRs for each letter. Also removed/corrected some entries that were not relevant/precise and augmented others. This PR has been sorted as well.
@larsoner larsoner merged commit 4c56f4f into codespell-project:master May 8, 2018
@luzpaz luzpaz deleted the letter/g branch May 8, 2018 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants