Skip to content

Fix maybe-uninitialized warnings#3199

Merged
ahojnnes merged 2 commits into
colmap:mainfrom
papjuli:fix-maybe-uninitialized-warnings
Mar 4, 2025
Merged

Fix maybe-uninitialized warnings#3199
ahojnnes merged 2 commits into
colmap:mainfrom
papjuli:fix-maybe-uninitialized-warnings

Conversation

@papjuli

@papjuli papjuli commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

Fix some code that result in maybe-uninitialized compiler warnings:

  • best_model in ransac and loransac can be uninitialized -> use optional,
  • initialize Eigen matrices to 0 in EstimateRigid3d and other similar functions.

Also, don't turn the warning type off CMakeLists.txt.

Unfortunately, there are 3 other such warnings that originate outside, namely in boost graph.

@ahojnnes ahojnnes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@ahojnnes ahojnnes merged commit 8850169 into colmap:main Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants