Skip to content

Refactor feature extraction/matching to support other features#3465

Merged
ahojnnes merged 109 commits into
mainfrom
user/jsch/feature-refactor
Jul 9, 2025
Merged

Refactor feature extraction/matching to support other features#3465
ahojnnes merged 109 commits into
mainfrom
user/jsch/feature-refactor

Conversation

@ahojnnes

@ahojnnes ahojnnes commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@ahojnnes ahojnnes requested review from B1ueber2y and sarlinpe July 9, 2025 09:27

@sarlinpe sarlinpe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

Comment thread src/colmap/ui/feature_extraction_widget.cc Outdated
Comment thread src/colmap/controllers/option_manager.h Outdated
Comment thread src/colmap/exe/feature.cc

@B1ueber2y B1ueber2y left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Very clean refactoring! Definitely very helpful for the other PR.

Comment thread src/pycolmap/feature/extraction.cc Outdated
Comment thread src/pycolmap/feature/matching.cc Outdated
Comment thread doc/install.rst
@ahojnnes ahojnnes enabled auto-merge (squash) July 9, 2025 17:18
Comment thread src/colmap/ui/feature_extraction_widget.cc Outdated
@ahojnnes ahojnnes merged commit a90ecc5 into main Jul 9, 2025
14 checks passed
@ahojnnes ahojnnes deleted the user/jsch/feature-refactor branch July 9, 2025 22:41
B1ueber2y added a commit that referenced this pull request Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants