Fix copying behaviors of empty bitmap.#3823
Merged
Merged
Conversation
B1ueber2y
changed the title
sarlinpe
reviewed
Dec 12, 2025
Comment on lines
+69
to
+70
| size_t width_ = 0; | ||
| size_t height_ = 0; |
Contributor
Author
There was a problem hiding this comment.
Yes. There is a default constructor of mvs::Image so i added a default value here. There is unfortunately no test coverage in the current codebase for the mvs::Image class.
ahojnnes
approved these changes
Dec 12, 2025
Contributor
|
Thank you for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3809