Refactor and improve track establishment. #3965
Merged
Merged
Conversation
ahojnnes
approved these changes
Jan 7, 2026
2f0bf3a to
a70cbf2
Compare
Contributor
Author
|
Regression: |
ahojnnes
approved these changes
Jan 9, 2026
ahojnnes
pushed a commit
that referenced
this pull request
Jan 9, 2026
A follow up of #3965. Also included some minor cosmetic improvements, including: * remove max_num_views_per_track and max_num_tracks, which were not useful here and set to the max limit. * rename unfiltered_points3D to candidate_points3D. * directly add point3D in reconstruction in the logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file becomes quite short. Not sure if this needs to be a stand-alone file anymore. Can probably move to sth like global_mapper_impl.h/cc or just inline in global_mapper.h/cc.
The logic should be equivalent.