Add option to control refinement of points 3D in bundle adjuster#4012
Merged
Conversation
This was referenced Jan 15, 2026
B1ueber2y
approved these changes
Jan 15, 2026
lpanaf
approved these changes
Jan 15, 2026
B1ueber2y
added a commit
that referenced
this pull request
Jan 17, 2026
…m option class. (#4016) Enabled by #4012. * Add a min_track_length option in colmap BA. * Drop custom option class and directly store colmap::BundleAdjustmentOptions. * Align the new names in option manager. * Drop the confusing "optimize_rotations" option as the default in global mapper is to run BA for two times (one with rotation fixed and one with full BA). Add an option to skip the fixed-rotation stage in bundle adjustment in the global pipeline, and default it to false. We therefore can drop the custom BA wrapper in glomap and directly use the colmap one in the global mapper. Logic is kept equivalent to before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements: #2117