fix: update JetBrains binary test expected files#11890
Merged
Merged
Conversation
The build produces a ripgrep (rg) binary, not esbuild. Also guard against subprocess being undefined in afterAll when beforeAll fails.
dosubot
Bot
added
the
size:XS
Contributor
|
Docs Review: No documentation updates needed. This PR contains internal test infrastructure changes only:
These changes don't affect user-facing functionality, APIs, or developer workflows. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Patrick-Erichsen
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuildwhen the build actually producesrg(ripgrep)afterAllagainstsubprocessbeing undefined whenbeforeAllfailsTest plan
Summary by cubic
Fix JetBrains binary tests by expecting
rg(ripgrep) instead ofesbuild, matching the build output. Also guard afterAll to only kill the subprocess when it exists, preventing failures if beforeAll fails.Written for commit 9205a0d. Summary will update on new commits.