🧭 fix: Reduce MCP Registry ACL Lookups#13195
Merged
Merged
Conversation
Owner
Author
|
@codex review |
danny-avila
marked this pull request as ready for review
May 19, 2026 15:06
danny-avila
force-pushed
the
danny-avila/fix-mcp-registry-acl-principals
branch
from
May 19, 2026 15:09
bd5c29f to
2e99a68
Compare
Owner
Author
|
@codex review |
Contributor
GitNexus: 🚀 deployedThe |
danny-avila
force-pushed
the
danny-avila/fix-mcp-registry-acl-principals
branch
from
May 19, 2026 15:19
2e99a68 to
02d5ce6
Compare
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
GitNexus: 🚀 deployedThe |
1 task
fuuuzzy
pushed a commit
to fuuuzzy/LibreChat
that referenced
this pull request
May 22, 2026
ThomasVuNguyen
pushed a commit
to ThomasVuNguyen/LibreChat
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I reduced redundant ACL principal resolution in the MCP registry DB lookup path and moved MCP-related Agent queries behind data-schemas methods.
ServerConfigsDB.getAll.packages/apino longer calls the Agent model directly for this flow.Change Type
Testing
cd packages/api && npx jest src/mcp/registry/__tests__/ServerConfigsDB.test.ts --runInBandcd api && npx jest server/services/__tests__/MCP.spec.js --runInBandnpm run build --workspace=@librechat/apiTest Configuration:
Checklist