✂️ fix: Cap Audit Chain Verification and Honor Client Cancellation#13903
Merged
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fuuuzzy
pushed a commit
to fuuuzzy/LibreChat
that referenced
this pull request
Jul 7, 2026
ThomasVuNguyen
pushed a commit
to ThomasVuNguyen/LibreChat
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
MAX_AUDIT_VERIFY_ROWSand extendVerifyAuditChainOptionswithisCancelled?: () => booleanandmaxRows?: numberso the methods layer can stop early.verifyAuditChainto observeisCancelledandmaxRows, close the cursor and return a bounded non-OK result on cancellation or row-limit overflow.verifyAuditLogHandlernow listens forres.once('close')/req.once('aborted'), passesisCancelledandMAX_AUDIT_VERIFY_ROWSto the methods layer, and skips writing a response if the client disconnected.packages/api/src/admin/auditLog.spec.tsandpackages/data-schemas/src/methods/auditLog.spec.ts, and export the new constant frompackages/data-schemas.Testing
npm run build:data-schemas, which completed successfully.npm run build:api, which completed successfully.cd packages/api && npx jest src/admin/auditLog.spec.ts --runInBand, which passed (34 tests).cd packages/data-schemas && MONGOMS_VERSION=7.0.14 npx jest src/methods/auditLog.spec.ts --runInBand, but the suite was blocked bymongodb-memory-serverfailing to download the MongoDB binary in this environment (HTTP 403), so the full methods-suite could not be executed here.Codex Task