🛂 fix: Re-Check execute_code Authorization on Event-Driven Tool Loads#13912
Merged
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
danny-avila
marked this pull request as ready for review
June 23, 2026 12:13
execute_code Authorization on Event-Driven Tool Loads
fuuuzzy
pushed a commit
to fuuuzzy/LibreChat
that referenced
this pull request
Jul 7, 2026
ThomasVuNguyen
pushed a commit
to ThomasVuNguyen/LibreChat
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bash_toolloading on the same per-agentexecute_codeauthorization used by initial tool definition loading.toolRegistrybefore loading them.execute_codeattempting to load code execution tools throughON_TOOL_EXECUTE.Root Cause
loadToolDefinitionsWrapperfiltered initial tool definitions against the agent's configured tools, butloadToolsForExecutiontrusted runtime tool names fromON_TOOL_EXECUTEtoo much. A model/tool-call path could requestbash_tooleven when the agent did not haveexecute_coderegistered.Validation
cd api && npx jest server/services/__tests__/ToolService.spec.js --runInBand --silentcd api && npx jest server/services/Endpoints/agents/initialize.spec.js --runInBand --silentgit diff --check -- api/server/services/ToolService.js api/server/services/__tests__/ToolService.spec.js