Revert Node 24.14.1 pin in default-build.yml#66979

Merged

wtgodbe merged 1 commit into

dotnet:mainfrom

wtgodbe:wtgodbe/unpin-node-2414

Jun 8, 2026

wtgodbe commented Jun 2, 2026 •

edited

Loading

Member

What

Undoes the Node version pinning .yml changes from #66465, while keeping the two installNodeJs: false additions and the Cache@2 continueOnError: true.

Specifically reverts, in .azure/pipelines/jobs/default-build.yml (both job blocks):

Install Node 24.14.1 → Install Node 24.x
version: 24.14.1 → version: 24.x
Cache/restore keys node24.14.1 → node24

Not touched

The installNodeJs: false additions in ci-public.yml and ci.yml are kept.
The continueOnError: true on the Cache@2 node_modules task is kept.
ci.yml's Node-install block from Disable npm audit to prevent ETIMEDOUT build failures #66465 was already removed on main by a later change, so nothing to revert there.
Non-.yml changes from Disable npm audit to prevent ETIMEDOUT build failures #66465 (.npmrc, eng/Npm.Workspace.nodeproj) are out of scope and untouched.

Relates to #66465

Copilot AI review requested due to automatic review settings

June 2, 2026 16:17

wtgodbe requested a review from a team as a code owner

June 2, 2026 16:17

Copilot started reviewing on behalf of wtgodbe

June 2, 2026 16:17

github-actions Bot added the area-infrastructure label

dotnet-policy-service Bot commented Jun 2, 2026

Contributor

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.


          Revert Node pin to 24.14.1 in default-build.yml

8ee1874

Undoes the Node version pinning (24.x -> 24.14.1 and the node24 -> node24.14.1
cache key changes) introduced in dotnet#66465, while keeping the installNodeJs: false
additions and the Cache@2 continueOnError: true.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

wtgodbe force-pushed the wtgodbe/unpin-node-2414 branch from e4922c4 to 8ee1874 Compare

June 2, 2026 16:19

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Contributor

Pull request overview

This PR reverts the Node.js patch-version pinning in the shared AzDO default-build.yml job template (back to 24.x), while preserving the existing approach of conditionally installing Node based on the installNodeJs parameter.

Changes:

Revert UseNode@1 from 24.14.1 back to 24.x in both job blocks.
Update node_modules cache keys from node24.14.1 back to node24 for broader reuse.
Remove continueOnError: true from the Cache@2 node_modules task.

wtgodbe changed the title ~~Revert Node 24.14.1 pin in default-build.yml (keep installNodeJs: false)~~ Revert Node 24.14.1 pin in default-build.yml

wtgodbe commented Jun 2, 2026

Member Author

Seeing if nodejs/node#62991 has been resolved

Youssef1313 approved these changes

View reviewed changes

Youssef1313 left a comment

Member

Let's run multiple times before merge to ensure it was indeed fixed

wtgodbe commented Jun 2, 2026

Member Author

Let's run multiple times before merge to ensure it was indeed fixed

Yep, that's the plan

wtgodbe commented Jun 2, 2026 •

edited

Loading

Member Author

1st run all good
2nd run all good
3rd run all good
4th run all good
5th run all good
6th run all good
7th run all good
8th run all good

wtgodbe commented Jun 2, 2026

Member Author

/azp run

azure-pipelines Bot commented Jun 2, 2026

Azure Pipelines successfully started running 2 pipeline(s).

wtgodbe commented Jun 2, 2026

Member Author

/azp run

azure-pipelines Bot commented Jun 2, 2026

Azure Pipelines successfully started running 2 pipeline(s).

wtgodbe commented Jun 2, 2026

Member Author

/azp run

azure-pipelines Bot commented Jun 2, 2026

Azure Pipelines successfully started running 2 pipeline(s).

wtgodbe commented Jun 3, 2026

Member Author

/azp run

azure-pipelines Bot commented Jun 3, 2026

Azure Pipelines successfully started running 2 pipeline(s).

wtgodbe commented Jun 3, 2026

Member Author

/azp run

azure-pipelines Bot commented Jun 3, 2026

Azure Pipelines successfully started running 2 pipeline(s).

wtgodbe commented Jun 3, 2026

Member Author

/azp run

azure-pipelines Bot commented Jun 3, 2026

Azure Pipelines successfully started running 2 pipeline(s).

wtgodbe mentioned this pull request

Revert "Pin Node to 24.14.1 to work around npm ci 0xDEAD bug" dotnet/dotnet#6998

Merged

This was referenced Jun 3, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

wtgodbe commented Jun 3, 2026

Member Author

/azp run

azure-pipelines Bot commented Jun 3, 2026

Azure Pipelines successfully started running 2 pipeline(s).

wtgodbe commented Jun 3, 2026

Member Author

/azp run

azure-pipelines Bot commented Jun 3, 2026

Azure Pipelines successfully started running 2 pipeline(s).

wtgodbe merged commit 672741d into dotnet:main

19 of 25 checks passed

dotnet-maestro Bot mentioned this pull request

[main] Source code updates from dotnet/aspnetcore dotnet/dotnet#7109

Merged

dotnet-milestone-bot Bot added this to the 11.0-preview6 milestone

wtgodbe mentioned this pull request

Pin Node.js to 24.14.1 to avoid v24.15.0+ native crash #67402

Merged

wtgodbe added a commit to wtgodbe/aspnetcore that referenced this pull request


          Pin Node.js to 24.14.1 to avoid v24.15.0+ native crash

3b859d5

Node.js v24.15.0 and every later 24.x release (24.16.0, 24.17.0, 24.18.0)
cause intermittent native crashes in node.exe on Windows CI agents. The
current signature is a Windows access violation (0xC0000005, npm error
code 3221225477 / MSBuild exit code -1073741819) inside node.exe while
running 'rollup -c' for the Components JS workspaces.

Crash frequency rises with each release; over the past week the rollup
crash was observed on 24.16.0 (2x), 24.17.0 (3x) and 24.18.0 (4x) on the
Build: Windows leg, while 24.14.1 had zero crashes. This matches the
earlier v24.15.0 incident (0xDEAD during npm-ci extraction) that led to
the original 24.14.1 pin (dotnet#66465), which was reverted in dotnet#66979.

Re-pin to 24.14.1 (last release with zero observed crashes) until the
upstream Node issue is fixed. Also update cache keys to avoid stale
node_modules from 24.x builds.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

wtgodbe added a commit that referenced this pull request


          Pin Node.js to 24.17.0 to avoid v24.18.0 native crash (#67402)

849620a

Node.js v24.18.0 (released Jun 23) causes intermittent native crashes in
node.exe during the rollup bundling step of the Components JS build on
Windows CI agents. The crash is a Windows access violation (0xC0000005,
npm error code 3221225477 / MSBuild exit code -1073741819) inside
node.exe while running 'rollup -c' for the JS workspaces.

CI floats 'version: 24.x' and began pulling v24.18.0 at ~2026-06-24
04:00 UTC (within hours of its release); the crash storm started the same
day. Builds on v24.17.0 and earlier are clean. This mirrors the earlier
v24.15.0 incident that led to the 24.14.1 pin (#66465), which was later
reverted (#66979).

Pin to 24.17.0 (last known-good) until the upstream Node issue is fixed.
Also update cache keys to avoid stale node_modules from 24.x builds.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure