Skip to content

[BrowserDebugProxy] Remove exception details from error report#111169

Merged
mdh1418 merged 2 commits into
dotnet:mainfrom
mdh1418:browser_debug_proxy_expression_evaluation_count
Jan 8, 2025
Merged

[BrowserDebugProxy] Remove exception details from error report#111169
mdh1418 merged 2 commits into
dotnet:mainfrom
mdh1418:browser_debug_proxy_expression_evaluation_count

Conversation

@mdh1418

@mdh1418 mdh1418 commented Jan 7, 2025

Copy link
Copy Markdown
Member

We don't need to send the exception details in the error report. Remove the information as we can just grab the count.

Associated PR: microsoft/vscode-js-debug#2158

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

@mdh1418 mdh1418 force-pushed the browser_debug_proxy_expression_evaluation_count branch from bb5091c to 7fdea01 Compare January 7, 2025 20:36
@mdh1418 mdh1418 force-pushed the browser_debug_proxy_expression_evaluation_count branch from 7fdea01 to 237b757 Compare January 7, 2025 20:37
@mdh1418 mdh1418 requested a review from tommcdon January 7, 2025 20:39
@mdh1418 mdh1418 force-pushed the browser_debug_proxy_expression_evaluation_count branch from e7198ce to e63fe9e Compare January 7, 2025 21:23
@thaystg

thaystg commented Jan 7, 2025

Copy link
Copy Markdown
Member

I think we can backport it for .NET 9 also.

@tommcdon tommcdon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdh1418 mdh1418 merged commit b054be3 into dotnet:main Jan 8, 2025
@mdh1418

mdh1418 commented Jan 8, 2025

Copy link
Copy Markdown
Member Author

/backport to release/9.0-staging

@github-actions

github-actions Bot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12674606859

@github-actions github-actions Bot locked and limited conversation to collaborators Feb 8, 2025
@mdh1418 mdh1418 deleted the browser_debug_proxy_expression_evaluation_count branch June 24, 2025 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants