Skip to content

skip over undefined $EB_PYTHON/$EB_INSTALLPYTHON in eb wrapper script#4080

Merged
branfosj merged 1 commit into
easybuilders:developfrom
Flamefire:skip_empty_python
Sep 21, 2022
Merged

skip over undefined $EB_PYTHON/$EB_INSTALLPYTHON in eb wrapper script#4080
branfosj merged 1 commit into
easybuilders:developfrom
Flamefire:skip_empty_python

Conversation

@Flamefire

Copy link
Copy Markdown
Contributor

Check if the current $python_cmd is empty and skip all checks in that case. This avoids useless checks and log output in VERBOSE mode.

Also extend the CI test to catch this issue.

Check if the current $python_cmd is empty and skip all checks in that case.
This avoids useless checks and log output in VERBOSE mode.

Also extend the CI test to catch this issue.

@branfosj branfosj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@branfosj branfosj added this to the next release (4.6.2?) milestone Sep 21, 2022
@branfosj branfosj merged commit 582a433 into easybuilders:develop Sep 21, 2022
@Flamefire Flamefire deleted the skip_empty_python branch September 21, 2022 17:22
@boegel boegel changed the title skip over unset $EB_PYTHON/$EB_INSTALLPYTHON skip over undefined $EB_PYTHON/$EB_INSTALLPYTHON in eb wrapper script Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants