make vstring/version variables in LooseVersion read-only#4156
Merged
Conversation
dafe426 to
9741023
Compare
Contributor
Author
|
There was a use case that caused now test failures: I still think this is a good idea because if anyone was to print the |
It assigns back to `.version` which is now unsupported
9741023 to
e4e6989
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exposed "public" members
.versionand.vstringmust not be modified from outside as they belong together. Hence put them into properties.I was also thinking about the case of
LooseVersion(None)which can easily happen withLooseVersion(get_software_version('Bazel')). One approach was to compare that equal toNoneorLooseVersion(None)and "less" otherwise. But that might be surprising and hence better/safer isif LooseVersion(...).version is NoneI hence added that to the test suite to show an example and kept my WIP commit in the history if we later decide otherwise.
@boegel This should go into the next release which adds this class.