Honor --disable-module-extensions configuration option#4971
Merged
boegel merged 1 commit intoAug 9, 2025
Conversation
Commit a48c6bb dismissed the check of 'module_extensions' build option before generating module extensions. As a result it was not possible to disable module extensions with --disable-module-extensions. Commit a48c6bb also moved extension generation code behind the `elif conflict:` condition branch. This commit restores a correct check for 'module_extensions' build option and provides a test to check behavior when 'module_extensions' is disabled. Fixes easybuilders#4887 Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
boegel
changed the title
--disable-module-extensions configuration option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit a48c6bb dismissed the check of 'module_extensions' build option before generating module extensions. As a result it was not possible to disable module extensions with --disable-module-extensions. Commit a48c6bb also moved extension generation code behind the
elif conflict:condition branch.This commit restores a correct check for 'module_extensions' build option and provides a test to check behavior when 'module_extensions' is disabled.
Fixes #4887
Supersedes #4898