Skip to content

Add decorator to ignore PR test failures due to rate limit#5019

Merged
lexming merged 1 commit into
easybuilders:developfrom
Flamefire:rate-limit-test
Nov 18, 2025
Merged

Add decorator to ignore PR test failures due to rate limit#5019
lexming merged 1 commit into
easybuilders:developfrom
Flamefire:rate-limit-test

Conversation

@Flamefire

Copy link
Copy Markdown
Contributor

The decorator checks if the test is run in a GitHub PR and ignores any error caused by a "HTTP 403" rate-limit exception.

The decorator checks if the test is run in a GitHub PR and ignores any
error caused by a "HTTP 403" rate-limit exception.

@lexming lexming left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as there is no other solution as long as EB relies on unauthenticated access to github.

I'll wait for feedback from other maintainers before merging.

@Flamefire

Copy link
Copy Markdown
Contributor Author

@boegel wrote in Slack:

Seems sensible, but we have to be careful that this won’t accidentally hide failing things that we can/should test…

My answer:

It is only skipped in PRs, so at least it will turn up post-merge for the unlikely case the rate limit hid the actual error

@lexming

lexming commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Merging, thanks @Flamefire !

@lexming lexming merged commit 8de5e93 into easybuilders:develop Nov 18, 2025
37 checks passed
@Flamefire Flamefire deleted the rate-limit-test branch November 18, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants