Skip to content

fix test_github_merge_pr by using more recent easyconfig PR#5197

Merged
Micket merged 1 commit into
easybuilders:developfrom
boegel:fix_test_github_merge_pr
Jun 13, 2026
Merged

fix test_github_merge_pr by using more recent easyconfig PR#5197
Micket merged 1 commit into
easybuilders:developfrom
boegel:fix_test_github_merge_pr

Conversation

@boegel

@boegel boegel commented Jun 13, 2026

Copy link
Copy Markdown
Member

fix for:

======================================================================
FAIL: test_github_merge_pr (test.framework.options.CommandLineOptionsTest)
Test use of --merge-pr (dry run)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Volumes/work/EasyBuild/easybuild-framework/test/framework/options.py", line 5190, in test_github_merge_pr
    self.assertEqual(stderr.strip(), expected_stderr)
  File "/Volumes/work/EasyBuild/easybuild-framework/easybuild/base/testing.py", line 89, in assertEqual
    super().assertEqual(a, b, msg=msg)
AssertionError: '* test suite passes: (status: None) => no[110 chars]way)' != ''
- * test suite passes: (status: None) => not eligible for merging!
-
- WARNING: Review indicates this PR should not be merged (use -f/--force to do so anyway)

----------------------------------------------------------------------

nothing unusual, we need to move to a more recent PR on a semi-regular basis, see also:

@Micket Micket left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 6a8ce5c into easybuilders:develop Jun 13, 2026
41 checks passed
@boegel boegel deleted the fix_test_github_merge_pr branch June 13, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants