Preserve ordering of schema for docs#111
Merged
Merged
Conversation
JonoPrest
force-pushed
the
jp/preserve-schema-order
branch
from
27cd2b0 to
09688e6
Compare
JonoPrest
commented
Aug 7, 2024
Comment on lines
+14
to
+16
| "name": { | ||
| "description": "Name of the project", | ||
| "type": "string" |
Collaborator
Author
There was a problem hiding this comment.
Unfortunately I looked at the code for schema rs and it will always order the keyword "description" first for it's own objects so we basically just have a name collision there. I don't think it's very important to change right now. Not sure if we should even keep description in the schema.
Member
There was a problem hiding this comment.
Hmmm, I think it's not used in any way.
DZakh
approved these changes
Aug 7, 2024
Comment on lines
+14
to
+16
| "name": { | ||
| "description": "Name of the project", | ||
| "type": "string" |
Member
There was a problem hiding this comment.
Hmmm, I think it's not used in any way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.