Remove cargo-cache action from build-platforms workflow#1231
Merged
Conversation
Build cache in release workflows is a supply chain risk (cache poisoning can inject tampered artifacts into published binaries) and hurts reproducibility. The time savings is negligible for infrequent tag-triggered builds. https://claude.ai/code/session_014sbg79Er1e6Mw2QTMeLuYE
Contributor
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe build-platforms workflow documentation is updated to explicitly clarify that Cargo caching is intentionally omitted from the build process to prevent tampered or poisoned cached artifacts. This replaces implicit behavior with explicit inline comments. ChangesCargo Cache Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the cargo-cache action step from the build-platforms CI workflow.
Changes
./.github/actions/cargo-cacheaction invocation that was caching Cargo artifacts per target platformRationale
This simplifies the CI workflow by eliminating the per-target cargo caching step. This may reduce CI complexity or address issues with the caching strategy for multi-platform builds.
https://claude.ai/code/session_014sbg79Er1e6Mw2QTMeLuYE
Summary by CodeRabbit