Add validation for endblock on finite chains#191
Merged
Conversation
DZakh
reviewed
Sep 11, 2024
Comment on lines
+140
to
+144
| Err(anyhow!( | ||
| "Network {} has a finite end block of {}. Please set an end_block that is \ | ||
| less than or equal to the finite end block in your config or set \ | ||
| \"unordered_multichain_mode\" to true. Your multichain indexer will \ | ||
| otherwise be stuck when it reaches the end of this chain.", |
Member
There was a problem hiding this comment.
What do you think of setting it by ourselves when we parse human config to system config?
Collaborator
Author
There was a problem hiding this comment.
I would rather it's explicit than inferred. In case we make a mistake. Say we added another deprecated chain and mess up the finite end_block, then it's easier to get this reported.
DZakh
approved these changes
Sep 12, 2024
JonoPrest
force-pushed
the
jp/add-endblock-for-goerli
branch
from
4efec9a to
deebf1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #183