Add integration test for wildcard indexing with filters#197
Merged
Conversation
JonoPrest
commented
Sep 13, 2024
Comment on lines
+262
to
+272
| let topicSelections = switch topic0sGrouped { | ||
| | [] => topicSelectionWithFilters | ||
| | topic0sGrouped => | ||
| [ | ||
| LogSelection.makeTopicSelection(~topic0=topic0sGrouped)->Utils.unwrapResultExn, | ||
| ]->Belt.Array.concat(topicSelectionWithFilters) | ||
| } | ||
|
|
||
| { | ||
| isWildcard, | ||
| topicSelections: Belt.Array.concat(topicSelectionWithFilters, [topicSelectionNoFilters]), | ||
| topicSelections, |
Collaborator
Author
There was a problem hiding this comment.
This was a bug I picked up during the test. When there are filters selected this threw an error because it would try and create a topic selection with no topic0s
JonoPrest
commented
Sep 13, 2024
Comment on lines
+3
to
+19
| const DAI_ADDRESS = "0x6B175474E89094C44Da98b954EedeAC495271d0F"; | ||
| UniswapV3Factory.PoolCreated.handler( | ||
| async ({ event, context }) => { | ||
| context.PoolCreated.set({ | ||
| id: event.transaction.hash + event.logIndex.toString(), | ||
| token0: event.params.token0, | ||
| token1: event.params.token1, | ||
| fee: event.params.fee, | ||
| tickSpacing: event.params.tickSpacing, | ||
| pool: event.params.pool, | ||
| }); | ||
| }, | ||
| { | ||
| wildcard: true, | ||
| eventFilters: [{ token0: DAI_ADDRESS }, { token1: DAI_ADDRESS }], | ||
| }, | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
I'm quite boolish on this 🐮, feels super powerful
JonoPrest
force-pushed
the
jp/wildcard-test
branch
from
9a43a7c to
bb83faa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.