More benchmarks#218
Merged
Merged
Conversation
JonoPrest
commented
Sep 19, 2024
JonoPrest
commented
Collaborator
- Separates benchmarks for root register and dynamic contracts register since those will be extremely different sizes of queries.
- Adds benchmark for pruning entity history (might remove is since it seems completely insignificant on the couple of runs I've tried)
JonoPrest
force-pushed
the
jp/add-data-pruning-benchmark
branch
from
dcddb98 to
f56e5f0
Compare
JonoPrest
force-pushed
the
jp/add-data-pruning-benchmark
branch
from
f56e5f0 to
6909caf
Compare
DZakh
approved these changes
Sep 23, 2024
Comment on lines
86
to
+89
| eventProcessing: s.field("eventProcessing", S.array(EventProcessing.schema)), | ||
| updateEndOfBlockRangeScannedData: s.field( | ||
| "updateEndOfBlockRangeScannedData", | ||
| S.array(UpdateEndOfBlockRangeScannedData.schema), |
Member
There was a problem hiding this comment.
Maybe S.schema will be more convinient here DX-wise, since it doesn't require duplicating the field name.
Collaborator
Author
There was a problem hiding this comment.
Can you link a doc or share an example? I'm not sure I understand exactly.
Member
There was a problem hiding this comment.
Collaborator
Author
There was a problem hiding this comment.
Ah nice I understand 👍🏼 yeah think that's better.
| blockTimestampThreshold, | ||
| nextEndOfBlockRangeScannedData, | ||
| }) => | ||
| let timeRef = Hrtime.makeTimer() |
Member
There was a problem hiding this comment.
Won't it be a problem having it outside of Env.saveBenchmarkData check?
Collaborator
Author
There was a problem hiding this comment.
It's just a variable with with a value for time. It would hardly affect performance.
JonoPrest
force-pushed
the
jp/add-data-pruning-benchmark
branch
from
6909caf to
2eb5d3a
Compare
JonoPrest
force-pushed
the
jp/add-data-pruning-benchmark
branch
from
2eb5d3a to
713f885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
