Add benchmarks to prometheus#346
Merged
Merged
Conversation
JonoPrest
commented
Nov 19, 2024
Comment on lines
+109
to
+147
| module Stats = { | ||
| open Belt | ||
| type t = { | ||
| n: int, | ||
| mean: float, | ||
| @as("std-dev") stdDev: float, | ||
| min: float, | ||
| max: float, | ||
| sum: float, | ||
| } | ||
|
|
||
| let round = (float, ~precision=2) => { | ||
| let factor = Js.Math.pow_float(~base=10.0, ~exp=precision->Int.toFloat) | ||
| Js.Math.round(float *. factor) /. factor | ||
| } | ||
|
|
||
| let makeFromDataSet = (dataSet: SummaryData.DataSet.t) => { | ||
| let n = dataSet.count | ||
| let countBigDecimal = n->BigDecimal.fromInt | ||
| let mean = dataSet.sum->BigDecimal.div(countBigDecimal) | ||
| let variance = | ||
| dataSet.sumOfSquares | ||
| ->BigDecimal.div(countBigDecimal) | ||
| ->BigDecimal.minus(mean->BigDecimal.times(mean)) | ||
| let stdDev = BigDecimal.sqrt(variance) | ||
| let roundBigDecimal = bd => | ||
| bd->BigDecimal.decimalPlaces(dataSet.decimalPlaces)->BigDecimal.toNumber | ||
| let roundFloat = float => float->round(~precision=dataSet.decimalPlaces) | ||
| { | ||
| n, | ||
| mean: mean->roundBigDecimal, | ||
| stdDev: stdDev->roundBigDecimal, | ||
| min: dataSet.min->roundFloat, | ||
| max: dataSet.max->roundFloat, | ||
| sum: dataSet.sum->roundBigDecimal, | ||
| } | ||
| } | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Moved out of the "Summary" module below
JonoPrest
commented
Nov 19, 2024
Comment on lines
+207
to
+230
| let saveLiveMetrics = if ( | ||
| Env.Benchmark.saveDataStrategy->Env.Benchmark.SaveDataStrategy.shouldSavePrometheus | ||
| ) { | ||
| let throttlerMapping = ThrottlerMapping.make() | ||
|
|
||
| (dataSet: SummaryData.DataSet.t, ~group, ~label) => { | ||
| let throttler = throttlerMapping->ThrottlerMapping.get(~group, ~label) | ||
| throttler->Throttler.schedule(() => { | ||
| let {n, mean, stdDev, min, max, sum} = dataSet->Stats.makeFromDataSet | ||
| Prometheus.setBenchmarkSummaryData( | ||
| ~group, | ||
| ~label, | ||
| ~n, | ||
| ~mean, | ||
| ~stdDev, | ||
| ~min, | ||
| ~max, | ||
| ~sum, | ||
| )->Promise.resolve | ||
| }) | ||
| } | ||
| } else { | ||
| (_dataSet, ~group as _, ~label as _) => () | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
If ENVIO_SAVE_BENCHMARK_DATA_STRATEGY="prometheus" this will return true. I black boxed the strategy type since we may want to introduce other things like saving to postgres orboth prometheus and another type etc.
JonoPrest
commented
Nov 19, 2024
| let throttlerMapping = ThrottlerMapping.make() | ||
|
|
||
| (dataSet: SummaryData.DataSet.t, ~group, ~label) => { | ||
| let throttler = throttlerMapping->ThrottlerMapping.get(~group, ~label) |
Collaborator
Author
There was a problem hiding this comment.
Throttler for setting prometheus is per group/label of the data set
DZakh
approved these changes
Nov 19, 2024
DZakh
left a comment
DZakh
left a comment
Member
There was a problem hiding this comment.
Looks good, but I'd like to have a single env var for the benchmark configuration
Comment on lines
+61
to
+78
| let shouldSaveData = envSafe->EnvSafe.get("ENVIO_SAVE_BENCHMARK_DATA", S.bool, ~fallback=false) | ||
| let saveDataStrategy = | ||
| envSafe->EnvSafe.get( | ||
| "ENVIO_SAVE_BENCHMARK_DATA_STRATEGY", | ||
| SaveDataStrategy.schema, | ||
| ~fallback=SaveDataStrategy.default, | ||
| ) |
Member
There was a problem hiding this comment.
How about having a single env var with options:
- true (JsonFile)
- json-file (JsonFile)
- prometheus (Prometheus)
Collaborator
Author
There was a problem hiding this comment.
Ok sure that works 👍🏼
Collaborator
Author
There was a problem hiding this comment.
@DZakh check the latest commit and lmk if you're happy 👍🏼
JonoPrest
force-pushed
the
jp/benchmark-to-prometheus
branch
from
9e938d2 to
599280c
Compare
DZakh
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.