Skip to content

WIP: Custom RPC client#356

Merged
DZakh merged 6 commits into
mainfrom
dz/custom-rpc-client
Nov 28, 2024
Merged

WIP: Custom RPC client#356
DZakh merged 6 commits into
mainfrom
dz/custom-rpc-client

Conversation

@DZakh

@DZakh DZakh commented Nov 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
  • Downgrade rescript-schema because there's a bug with reverse converting some unions. Not related to us, but I was afraid that it might happen for some RPC requests
  • Vendor rescript-rest and use it for RPC.res
  • Vendor rescript-express

@DZakh DZakh requested a review from JonoPrest November 25, 2024 15:08
JonoPrest
JonoPrest reviewed Nov 27, 2024
View reviewed changes
Comment thread scenarios/test_codegen/rescript.json
"helpers",
"envio"
"envio",
"@glennsl/rescript-fetch"

@JonoPrest JonoPrest Nov 27, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double check

JonoPrest
JonoPrest approved these changes Nov 27, 2024
View reviewed changes

@JonoPrest JonoPrest left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🥇

@DZakh DZakh enabled auto-merge (squash) November 28, 2024 09:07
@DZakh DZakh merged commit f723e33 into main Nov 28, 2024
@DZakh DZakh deleted the dz/custom-rpc-client branch November 28, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonoPrest JonoPrest JonoPrest approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DZakh @JonoPrest