Add getWhere Gt operator#413
Merged
Merged
Conversation
DZakh
force-pushed
the
dz/get-where-gt
branch
from
2213dc8 to
53d024e
Compare
JonoPrest
reviewed
Jan 16, 2025
| fieldName: string, | ||
| fieldValue: fieldValue, | ||
| fieldValueSchema: S.t<fieldValue>, | ||
| operator: TableIndices.Operator.t, |
Collaborator
There was a problem hiding this comment.
Doesn't the index contain the operator?
JonoPrest
reviewed
Jan 16, 2025
Comment on lines
+124
to
+127
| let queryType = switch operator { | ||
| | Eq => "whereEq" | ||
| | Gt => "whereGt" | ||
| } |
Collaborator
There was a problem hiding this comment.
string coersian could work fine here to remove an additional switch. Not a problem though
JonoPrest
approved these changes
Jan 16, 2025
JonoPrest
left a comment
JonoPrest
left a comment
Collaborator
There was a problem hiding this comment.
Awesome! It's actually a lot more extensible than I remembered. We should be able to add the others without too much hassle.
DZakh
force-pushed
the
dz/get-where-gt
branch
from
53d024e to
22d112b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #379