Fix scanned blocks clean up for a single chain indexers#429
Merged
Conversation
JonoPrest
reviewed
Jan 20, 2025
| updatedChainFetcher.chainConfig.confirmedBlockThreshold, | ||
| blockTimestampThreshold: chainManager | ||
| ->ChainManager.getEarliestMultiChainTimestampInThreshold | ||
| ->Option.getWithDefault(0), |
Collaborator
There was a problem hiding this comment.
Ah so this was the bug beforehand?
Member
Author
There was a problem hiding this comment.
Actually, the LastBlockScannedHashes would operate only with blocks in reorg threshold (<200), but it only prunes blocks on response, so if the indexer restarts and the first query detects a rollback, then there'd be 15k+ calls to hypersync.
JonoPrest
approved these changes
Jan 20, 2025
JonoPrest
left a comment
JonoPrest
left a comment
Collaborator
There was a problem hiding this comment.
Awesome! Thanks for finding this 🙏🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.