House keeping: Fix all clippy warnings#463
Merged
Merged
Conversation
DZakh
approved these changes
Mar 4, 2025
| pub enum Abi { | ||
| Evm(EvmAbi), | ||
| Fuel(FuelAbi), | ||
| Fuel(Box<FuelAbi>), |
Member
There was a problem hiding this comment.
I never used Box. What is it needed for?
Collaborator
Author
There was a problem hiding this comment.
It's a clippy warning suggestion.
Box is like a c pointer. So it's an address on the heap. The reason to use it here is that the FuelAbi type is very big in memory. So the enum has to allocate all that memory even in the evm case. Clippy suggests using a pointer here instead to be more efficient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran the clippy linter for the codegen code and fixed all its warnings.