Event filtering by contract addresses#495
Merged
Merged
Conversation
Member
Author
|
@JonoPrest Here's the usage example #469 (comment) |
JonoPrest
reviewed
Apr 1, 2025
| // The idea is that it can only be coerced from fuel/evmEventConfig | ||
| // and it can include their fields. We prevent manual creation, | ||
| // so the fields are not overwritten and we can safely cast the type back to fuel/evmEventConfig | ||
| type eventConfig = private { |
Collaborator
There was a problem hiding this comment.
Do the fields still come up with lsp hover etc?
JonoPrest
reviewed
Apr 1, 2025
| ), | ||
| ) | ||
| | [topicSelection] => topicSelection | ||
| | ([topicSelection], _) if dynamicEventFilters->Utils.Array.isEmpty => { |
Collaborator
There was a problem hiding this comment.
Suggested change
| | ([topicSelection], _) if dynamicEventFilters->Utils.Array.isEmpty => { | |
| | ([topicSelection], []) => { |
JonoPrest
reviewed
Apr 1, 2025
Comment on lines
+206
to
+207
| | _ => | ||
| raise( | ||
| Source.GetItemsError( | ||
| UnsupportedSelection({ | ||
| message: "RPC data-source currently supports event filters only when there's a single wildcard event. Join our Discord channel, to get updates on the new releases.", | ||
| }), | ||
| ), | ||
| ) | ||
| } | ||
|
|
||
| // Some RPC providers would fail | ||
| // if we don't strip trailing empty topics | ||
| // also we need to change empty topics in the middle to null | ||
| let topics = switch topicSelection { | ||
| | {topic0, topic1: [], topic2: [], topic3: []} => [topic0] | ||
| | {topic0, topic1, topic2: [], topic3: []} => [topic0, topic1] | ||
| | {topic0, topic1: [], topic2, topic3: []} => [topic0, %raw(`null`), topic2] | ||
| | {topic0, topic1, topic2, topic3: []} => [topic0, topic1, topic2] | ||
| | {topic0, topic1: [], topic2: [], topic3} => [topic0, %raw(`null`), %raw(`null`), topic3] | ||
| | {topic0, topic1: [], topic2, topic3} => [topic0, %raw(`null`), topic2, topic3] | ||
| | {topic0, topic1, topic2: [], topic3} => [topic0, topic1, %raw(`null`), topic3] | ||
| | {topic0, topic1, topic2, topic3} => [topic0, topic1, topic2, topic3] | ||
| switch (dynamicEventFilters, selection.eventConfigs) { |
Collaborator
There was a problem hiding this comment.
Check that topic selection is empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.