Improve missing global contract error message#65
Merged
Conversation
|
Here's the diff of the codegen output.🙌🧠🦜 |
JasoonS
reviewed
Jul 10, 2024
| type NetworkId = u64; | ||
|
|
||
| #[derive(Debug, Serialize, Deserialize, Clone, PartialEq, JsonSchema)] | ||
| #[serde(deny_unknown_fields)] |
Contributor
There was a problem hiding this comment.
I thought we can put deny unknown fields everywhere besides in the top level - because it could be nice for a user to put some of their own config somewhere in the file also.
Although, they can just make their own config files, so I guess it doesn't matter if it is everywhere 👍 And less error prone
JasoonS
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After: