Implement updated bindings for hs client#88
Merged
Merged
Conversation
DZakh
approved these changes
Jul 26, 2024
Comment on lines
+13
to
+25
| let hscDecoder: ref<option<HyperSyncClient.Decoder.t>> = ref(None) | ||
| let getHscDecoder = () => | ||
| switch hscDecoder.contents { | ||
| | Some(decoder) => decoder | ||
| | None => | ||
| switch HyperSyncClient.Decoder.fromSignatures(T.config.allEventSignatures) { | ||
| | exception exn => | ||
| exn->ErrorHandling.mkLogAndRaise( | ||
| ~msg="Failed to instantiate a decoder from hypersync client, please double check your ABI or try using 'event_decoder: viem' config option", | ||
| ) | ||
| | decoder => decoder | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| let hscDecoder: ref<option<HyperSyncClient.Decoder.t>> = ref(None) | |
| let getHscDecoder = () => | |
| switch hscDecoder.contents { | |
| | Some(decoder) => decoder | |
| | None => | |
| switch HyperSyncClient.Decoder.fromSignatures(T.config.allEventSignatures) { | |
| | exception exn => | |
| exn->ErrorHandling.mkLogAndRaise( | |
| ~msg="Failed to instantiate a decoder from hypersync client, please double check your ABI or try using 'event_decoder: viem' config option", | |
| ) | |
| | decoder => decoder | |
| } | |
| } | |
| let hscDecoder: HyperSyncClient.Decoder.t = switch HyperSyncClient.Decoder.fromSignatures(T.config.allEventSignatures) { | |
| | exception exn => | |
| exn->ErrorHandling.mkLogAndRaise( | |
| ~msg="Failed to instantiate a decoder from hypersync client, please double check your ABI or try using 'event_decoder: viem' config option", | |
| ) | |
| | decoder => decoder | |
| } |
Collaborator
Author
There was a problem hiding this comment.
@DZakh I want this to be lazy and not required if viem decoder is chosen. Hence why I use a ref and a closure for a lazy instantiation/retrieval.
Co-authored-by: Dmitry Zakharov <dzakh.dev@gmail.com>
f28ce17 to
d80f4a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the int24 underflow issue reported by Jack on discord.
Until this: enviodev/hypersync-client-rust#34
is merged, released and updated at least in hs client node we can't merge this.
Unfortuantely the current signature model will break with collisions on event signatures (from multiple contracts) and it will break in the case that two contracts have the same event with different topic0.
So we can't include this yet.