[1] Prompt for API key on init#97
Merged
Merged
Conversation
JonoPrest
force-pushed
the
jp/init-api-key
branch
from
586ad10 to
0ff9af3
Compare
JonoPrest
force-pushed
the
jp/init-api-key
branch
from
2c4e448 to
9012eab
Compare
DZakh
requested changes
Aug 2, 2024
DZakh
left a comment
DZakh
left a comment
Member
There was a problem hiding this comment.
Super nice. Left some opinion on wording, but that's not critical.
But there are some blocking requests:
- Remove rescript/core and pnpm-lock changes
- Rename API token env var name
| Some(k) => Ok::<_, anyhow::Error>(Some(k)), | ||
| None if ecosystem.uses_hypersync() => { | ||
| let select = Select::new( | ||
| "Add an API token for HyperSync to your .env file?", |
Member
There was a problem hiding this comment.
I think we can omit mentioning the .env file, since it's an implementation detail and shouldn't really concern the user at the point.
Collaborator
Author
There was a problem hiding this comment.
Hmmm, although that's exactly what this is doing right? IMO I like that it makes it clear that all it's doing is helping you add a token to your .env file and you can manually do it later if you want.
| "@elastic/ecs-pino-format": "1.4.0", | ||
| "@envio-dev/hypersync-client": "0.3.4-rc.1", | ||
| "@glennsl/rescript-fetch": "0.2.0", | ||
| "@rescript/core": "1.5.0", |
Member
There was a problem hiding this comment.
Looks like a conflict. This should be removed
JonoPrest
commented
Aug 2, 2024
JonoPrest
force-pushed
the
jp/init-api-key
branch
from
98a76bc to
bd8e843
Compare
* Add hypersync api key environment variable * Make env api token optional and default in client
Co-authored-by: Dmitry Zakharov <dzakh.dev@gmail.com>
Co-authored-by: Dmitry Zakharov <dzakh.dev@gmail.com>
JonoPrest
force-pushed
the
jp/init-api-key
branch
from
bd8e843 to
e2a4082
Compare
DZakh
approved these changes
Aug 2, 2024
| @module("@envio-dev/hypersync-client") @scope("HypersyncClient") external new: cfg => t = "new" | ||
|
|
||
| let make = (~url) => new({url, enableChecksumAddresses: true}) | ||
| let defaultToken = "3dc856dd-b0ea-494f-b27e-017b8b6b7e07" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very open to rewording/renaming.
Screen.Recording.2024-07-30.at.17.46.22.mov