Suggestion: Include alias in the "Quick Fix->Insert Import"

[wyfok]

Describe the Bug

With the extension on VScode, when there is no proper import for an alias (e.g. pd for pandas) , the "Quick Fix -> Insert Import" will list out all possible imports. However, after selecting an import, the alias is not included at the end of the output. To properly fix the issue, user needs to go back to the top of the file and add the alias to the import. This somehow contradicts the benefit of "Inserting Import", at the very least the "Insert Import" cannot directly solve the missing import issue.

Sandbox Link

No response

(Only applicable for extension issues) IDE Information

Version: 0.46.3

[javabster]

Thanks for opening this issue, I think this is a nice idea to add to the IDE experience, we'll look into it. cc @kinto0

[spaceship-zebra]

I've also encountered this bug (I wouldn't call it a feature, as it results in an invalid import). Here is a minimal example to reproduce it:

# model.py
class MyModel: pass

# alias_user.py
from pyrefly_repro.model import MyModel as MyModelAlias

# normal_user.py
x: MyM # and continue typing

Pressing enter results in an invalid import:

# normal_user.py
from pyrefly_repro.model import MyModelAlias
x: MyModelAlias

[kinto0]

I think this issue was actually completed in #2312. I'll close it for now, but if I misunderstood feel free to reopen.

I've also encountered this bug (I wouldn't call it a feature, as it results in an invalid import). Here is a minimal example to reproduce it:

model.py

class MyModel: pass

alias_user.py

from pyrefly_repro.model import MyModel as MyModelAlias

normal_user.py

x: MyM # and continue typing

Pressing enter results in an invalid import:

normal_user.py

from pyrefly_repro.model import MyModelAlias
x: MyModelAlias

@spaceship-zebra thanks for the report - thought that seems slightly unrelated to this issue (this issue has to do with suggesting common alises, while yours is an incorrect import due to an alias). would you be able to open a new github issue for that?

[spaceship-zebra]

Sorry, I misunderstood the description then. Created #2495