Add __slots__ to expressions (trailofbits#1635)#3
Merged
Conversation
* Added support for proc/self/maps * Corrected formatting * Updated ProcSelfMaps object * Fix for codeclimate * Updates according to Eric H.'s feedback * Added a data class for ProcSelfMapInfo. May make a few more adustments to this * Changed address to a property in ProcSelfMapInfo * adding a rust binary test * Added a test for proc self to test_linux * Updated the address and perms property tests to use a regex * Updated the regex check
* Add an implementation of sys_llseek for Linux * Reformat a couple funny string literals * Add a docstring for `sys_llseek` This was taken mainly from the manpage. * Fix a broken log format string * Improve logging & exception messages in linux platform * Update docstring for sys_lseek * Remove redundant space in mmap mode strings * Clean up temp files after linux platform tests * Add some tests for the `sys_lseek` * blacken tests/native/test_syscalls.py * Fix implementation of sys_llseek; expand & refine tests * blacken manticore/platforms/linux.py * Add some type signatures * Fix type signatures; add more signatures * Fix a bad variable reference * More type signatures; fix typing issues with linux `sys_write()`
…1649) It turns out that in smaller programs, like examples/linux/binaries/multiple-styles, something like 15-20% of total runtime is spent redundantly initializing the Z3 solver!
* Restructure SMTLib to avoid multiple inheritance * Attempt to fix usage of Constant/Variable/Operation outside of expressions * Fix init arguments * Fix missing return statement in visit_ArraySelect * Add Missing ArrayVariable * Extraneous return statement * Rename ConstantType, VariableType, and OperationType Remove the 'Type' to make the diff smaller * Add __slots__ in Expressions * Blacken... * Fix mypy * Fix dropped array operand * Return output from visit_operation properly * Shrink diff * Shrink Diff 2 * Clean up visitor rewrite Much smaller diff now * Maybe this will fix the truffle tests? Who knows... * Remove NVM * Use setdefault for taint * Add test to check for required properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.