fix(emoji): reserve square box for img.emoji to avoid CLS#4685
Merged
Conversation
Twemoji SVGs are loaded from a CDN and the rendered <img> carries no intrinsic dimensions. With only `height: 1.5em` set and `width: auto`, the browser reserves zero width per emoji until each SVG downloads, reflowing surrounding text on load and producing visible Cumulative Layout Shift. All Twemoji glyphs are square, so declaring `aspect-ratio: 1` lets the browser derive the width immediately and reserve the correct box before the SVG arrives. Fixes #4681
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4681
Problem
img.emoji(the inline Twemoji<img>rendered by the formatter) is styled inextensions/emoji/less/forum.lesswith a height but nowidthand noaspect-ratio. The Twemoji SVGs are loaded from the jsDelivr CDN and the rendered<img>carries no intrinsic dimensions (the s9e formatter template emits<img alt="…" class="emoji" draggable="false" src="…"/>with nowidth/height).With
height: 1.5embutwidth: auto, the browser reserves zero width for each emoji until its SVG downloads, then reflows the surrounding text once each SVG arrives. On emoji-heavy posts this produces visible Cumulative Layout Shift (CLS), especially on first paint / cold CDN cache / throttled mobile connections.Fix
Every Twemoji glyph is square (1:1), so declaring
aspect-ratio: 1lets the browser derivewidth: 1.5emimmediately from the existing height and reserve the correct box before the SVG loads — eliminating the shift.This lives in the extension's own stylesheet rather than the generated formatter bundle, so it survives bundle regeneration and is deployment-agnostic (correct for every install).
Testing
Credit to @ekumanov for the report and the suggested fix.